Preact conversion #18
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojowen
commented
Jun 10, 2019
| @@ -4,6 +4,7 @@ | |||
| "description": "", | |||
| "scripts": { | |||
| "dev": "parcel index.html", | |||
| "dev-local": "LOCAL_DATA=true parcel index.html", | |||
There was a problem hiding this comment.
Set up to serve sheets data locally
TODO: Add npm command to download a given sheet to local data
mojowen
commented
Jun 10, 2019
| initDom(container); | ||
| render(<App sheetKey={sheetKey} />, container); | ||
|
|
||
| return null; |
There was a problem hiding this comment.
have been replacing everything after this - initDom is done but need to finish initMap initTable initDetails
|
Oh man so excited about this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting the app to Preact
Install Preact
Load dom structure via components
Progressively load sheets
Progressively load maps
Progressively load content and insert into dom
Map
Controls
Legends
Tests
React devtools working and everything